Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] simplify line drawing #6575

Merged
merged 2 commits into from
Oct 18, 2019
Merged

[perf] simplify line drawing #6575

merged 2 commits into from
Oct 18, 2019

Conversation

benmccann
Copy link
Contributor

This does one less if / else check for each point in the line by handling the first point outside the loop. It also calls helpers.previousItem only when the result will be used. These two improvements should be a performance boost

kurkle
kurkle previously approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/elements/element.line.js Outdated Show resolved Hide resolved
@etimberg etimberg merged commit 959ea08 into chartjs:master Oct 18, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @etimberg
[perf] simplify line drawing (chartjs#6575)
33644c6 
* Simplify line drawing

* Remove duplicate initialization
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
@renovate renovate bot mentioned this pull request Oct 14, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Oct 14, 2021
Closed
1 task
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @etimberg @kurkle