-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover styling for dataset in 'dataset' mode #6527
Conversation
I just had an idea. What if we call We could automatically look for options of the same name prefixed with |
I think it'd be nice to update I also think some of the other docs need to be updated as well like bar chart now that this is implemented generically. Maybe we can document hover generically? |
Agreed, but its not quite in the scope of this PR
Bar does not utilize |
@@ -52,6 +52,13 @@ The line chart allows a number of properties to be specified for each dataset. T | |||
| [`borderWidth`](#line-styling) | `number` | Yes | - | `3` | |||
| [`cubicInterpolationMode`](#cubicinterpolationmode) | `string` | Yes | - | `'default'` | |||
| [`fill`](#line-styling) | <code>boolean|string</code> | Yes | - | `true` | |||
| [`hoverBackgroundColor`](#line-styling) | [`Color`](../general/colors.md) | Yes | - | `undefined` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we document hoverCubicInterpolationMode
and hoverFill
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither of those work. We are not going through update
on hover, just updating the model with options and then render
.
So bezier control points don't get updated.
I did not investigate why hoverFill
does not work.
* Hover styling for dataset in 'dataset' mode
Dataset level hover styles for
dataset
mode.Pen
Closes: #2136
Partially solves: #3880 (hover only triggered by points still, not filled area as requested)