-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of borderWidth as object #6077
Conversation
This comment has been minimized.
This comment has been minimized.
both, me and codeclimate are happy about this now, feel free to review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with the pen for a while, and it all look good to me. Reducing the number of lines in element.rectangle.js seems to be a good sign😊
After a long chat with @simonbrunel and many tests with jsperf, applied some optiomizations to parsing. Also added a regression test for chart area clipping. Added regression test was inspired by the thought of it not working after this PR. That turns out to be false. MDN gives a misleading description to
|
After loads of more talk and testing with @simonbrunel, decided to go with option C A B C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option C looks good. The result is consistent with the arc element with borderAlign: 'inner'
.
Thanks @kurkle for this great work! |
Alternative to #6047
Pen (ef842ad)
Pen (c5df9c9)
Fixes: #5565
Fixes: #5071
Fixes: #5709
Fixes: #4681
Related: #3293 (fixed in master already)