Add onLeave callback to legend #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonrimmer don't worry about the code climate warning, but please do fix the failing test so that Travis succeeds |
jonrimmer
force-pushed
the
legend-onleave
branch
from
62b57dd to
b6d8f96
Compare
|
@benmccann Oops, sorry. Should be fixed now. |
benmccann
reviewed
Feb 9, 2019
benmccann
reviewed
Feb 9, 2019
benmccann
reviewed
Feb 10, 2019
benmccann
reviewed
Feb 11, 2019
kurkle
requested changes
Feb 12, 2019
kurkle
reviewed
Feb 12, 2019
benmccann
reviewed
Feb 13, 2019
benmccann
reviewed
Feb 13, 2019
|
@jonrimmer I like the cleanup! this PR will have to be rebased |
simonbrunel
reviewed
Feb 13, 2019
simonbrunel
reviewed
Feb 13, 2019
|
Looks good to me other than needing to be rebased |
jonrimmer
force-pushed
the
legend-onleave
branch
from
8db8a26 to
3d1b41c
Compare
jonrimmer
force-pushed
the
legend-onleave
branch
from
3d1b41c to
61a9eb8
Compare
|
Rebased |
benmccann
reviewed
Feb 14, 2019
kurkle
approved these changes
Feb 14, 2019
benmccann
approved these changes
Feb 14, 2019
nagix
approved these changes
Feb 20, 2019
etimberg
approved these changes
Feb 23, 2019
|
Thanks @jonrimmer |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
onLeavecallback to the legend plugin. This complements theonHovercallback, allowing the user to detect when the user has moused away from a formerly hovered legend item.This helps achieve the use-case of highlighting a particular series on hover as supported by other charting libraries.
It also adds an example page and tests for the legend plugin callbacks.