Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'parser' instead of deprecated 'format' #5769

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

Niladri24dutta
Copy link
Contributor

Fixes #5456

update line chart demo to replace deprecated 'format' property with the 'parser' property under the 'scales' option of chart.js configuration(as per moment.js documentation). This update removes the below warning while running the example -
options.time.format is deprecated and replaced by options.time.parser.

jsfiddle sample after using 'parser' : Demo

@Niladri24dutta
Copy link
Contributor Author

@benmccann Hi , Thanks for the approval , is there anything required from my end regarding this PR merge?

@simonbrunel simonbrunel added this to the Version 2.8 milestone Oct 16, 2018
@simonbrunel simonbrunel merged commit dfbb574 into chartjs:master Oct 16, 2018
@simonbrunel
Copy link
Member

Thanks @Niladri24dutta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants