-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log gulp error to Chart.js #5143
Changes from 7 commits
142e19d
58bb9fe
2414daa
08cf096
d2327ef
ecffc82
e490438
e21587b
ae0e7e7
c8388d6
251fcc3
0b39c03
6ad9149
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ var collapse = require('bundle-collapser/plugin'); | |
var argv = require('yargs').argv | ||
var path = require('path'); | ||
var package = require('./package.json'); | ||
var fs = require('fs'); | ||
|
||
var srcDir = './src/'; | ||
var outDir = './dist/'; | ||
|
@@ -79,9 +80,20 @@ function bowerTask() { | |
|
||
function buildTask() { | ||
|
||
var errorHandler = function (err) { | ||
util.log(util.colors.red('[Error]'), err.toString()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would move that line before |
||
var browserError = 'console.error("Gulp: ' + err.toString() + '")'; | ||
fs.writeFileSync(outDir+'Chart.js', browserError); | ||
fs.writeFileSync(outDir+'Chart.min.js', browserError); | ||
fs.writeFileSync(outDir+'Chart.bundle.js', browserError); | ||
fs.writeFileSync(outDir+'Chart.bundle.min.js', browserError); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @simonbrunel if possible, i would like to be able to see the errors directly in the browser. I prefer to work in the editor and the browser only, and not have to check the terminal. |
||
this.emit('end'); | ||
} | ||
|
||
var bundled = browserify('./src/chart.js', { standalone: 'Chart' }) | ||
.plugin(collapse) | ||
.bundle() | ||
.on('error', errorHandler) | ||
.pipe(source('Chart.bundle.js')) | ||
.pipe(insert.prepend(header)) | ||
.pipe(streamify(replace('{{ version }}', package.version))) | ||
|
@@ -96,6 +108,7 @@ function buildTask() { | |
.ignore('moment') | ||
.plugin(collapse) | ||
.bundle() | ||
.on('error', errorHandler) | ||
.pipe(source('Chart.js')) | ||
.pipe(insert.prepend(header)) | ||
.pipe(streamify(replace('{{ version }}', package.version))) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] can we move
var fs
beforevar package
since the later one is a local file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
while i'm at it, is there any logic in the order for the non local dependencies ? alphabetical, date of addition ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No guideline for the order because some require() may need other ones. I'm used to gather related dependencies (e.g.
gulp-*
) and declare thepackage.json
at the end.