Error if style is null (Bugfix) #4781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested in Chrome and when style(line 50) is null, style.toString is undefined Reason: typeof null equals "object" (at least in Chrome)
|
should do the same :) |
simonbrunel
requested changes
Sep 22, 2017
| @@ -47,7 +47,7 @@ var exports = module.exports = { | |||
| drawPoint: function(ctx, style, radius, x, y) { | |||
| var type, edgeLength, xOffset, yOffset, height, size; | |||
|
|
|||
| if (typeof style === 'object') { | |||
| if (style && typeof style === 'object') { | |||
There was a problem hiding this comment.
if (helpers.isObject(style))
There was a problem hiding this comment.
Actually, helpers.isObject doesn't work in this case since it returns true only for plain object.
|
Console (Chrome V8):
|
|
im so sry, can you revert the second change from this request |
|
My fault, |
|
i reverted the change also in my repo |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
I tested in Chrome and when style(line 50) is null, style.toString is undefined Reason: typeof null equals "object" (at least in Chrome)
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
I tested in Chrome and when style(line 50) is null, style.toString is undefined Reason: typeof null equals "object" (at least in Chrome)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested in Chrome and when style(line 50) is null, style.toString is undefined
Reason: typeof null equals "object" (at least in Chrome)