-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for Logarithmic Scale Tick Bug for values of 0 #4688
Conversation
range = helpers.log10(max) - Math.floor(helpers.log10(me.minNotZero)); | ||
var fontSize = helpers.getValueOrDefault(tickOpts.fontSize, Chart.defaults.global.defaultFontSize); | ||
var diff = fontSize; | ||
innerDimension -= diff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does subtracting diff
work when the axis is horizontal and the labels are rotated less than 90 degrees?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed fix for doesn't work for charts without 0, as can be seen in the attached chart. Problems
The pull request
Proposed fix Example |
A fix for this was implemented in #4913 |
Fix for iss#3917 and iss#2966.
The minNotZero value is based on fontSize now (like recomended here) (i closed the previous pr because of too many conflicts).