-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show radial scale labels correctly when rotated #4682
Conversation
@simonbrunel not sure the best test strategy for this since it's quite visual. If we think it's worthwhile, I can create a PNG image test for it. |
…labels did not appear in the correct places.
bb1112a
to
873fa80
Compare
We can try, but I think image tests will not work correctly because of the text. |
hmmm, ok :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to unit test this
Ok. merging since i don't think there is an easy way to unit test this |
…labels did not appear in the correct places. (chartjs#4682)
This is still an issue in version 2.9.4. yet seems to work on 2.6.0. Bug seems to be re-introduced in 2.7.0. A hacky solution I am currently using to draw vertical ticks when using startAngle.
|
…labels did not appear in the correct places. (chartjs#4682)
Did you ever get this fixed? Doesnt work for my project |
When the radial scale was rotated using
startAngle
, the labels no longer lined up with the lines.Fixes #3612
After Fix