Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate npm install #4542

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Remove duplicate npm install #4542

merged 1 commit into from
Jul 21, 2017

Conversation

benmccann
Copy link
Contributor

npm install gets run automatically. Having this here just slows it down by running it twice

simonbrunel
simonbrunel approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@simonbrunel simonbrunel merged commit 94099c1 into chartjs:master Jul 21, 2017
@simonbrunel simonbrunel added this to the Version 2.7 milestone Jul 21, 2017
yofreke pushed a commit to yofreke/Chart.js that referenced this pull request Dec 30, 2017
@benmccann @yofreke
Remove duplicate npm install (chartjs#4542)
772f5dc
nagix added a commit to nagix/chartjs-plugin-streaming that referenced this pull request Mar 2, 2018
@nagix
Remove duplicate npm install (chartjs/Chart.js#4542)
2095649
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @simonbrunel
Remove duplicate npm install (chartjs#4542)
e6ea398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
type: infrastructure
Projects
None yet
Milestone
Version 2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@benmccann @simonbrunel