Update Display Format table #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nagix
commented
Jun 24, 2017
nagix
commented
- Up to date with the latest code
- Added Example column
- Up to date with the latest code - Added Example column
simonbrunel
reviewed
Jun 24, 2017
There was a problem hiding this comment.
@nagix looks good, thanks :) in case you have more documentation fixes, can you pack all of them in the same PR?
| year | 'YYYY' | ||
| Name | Default | Example | ||
| --- | --- | --- | ||
| millisecond | 'h:mm:ss.SSS a' | 11:20:01.123 AM |
There was a problem hiding this comment.
Good catch for millisecond :)
| If this is a function, it must return a moment.js object given the appropriate data value. |
There was a problem hiding this comment.
What's the change on this line?
There was a problem hiding this comment.
I guess my editor may have inserted a newline at the end of file. I think this is a good practice.
There was a problem hiding this comment.
Agree, I didn't notice it was the EOF.
|
@simonbrunel Thanks for the review. I have no more fixes for now, but I will pack if I make further fixes. |
simonbrunel
approved these changes
Jun 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.