Line height setting for scale titles #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… line height, so setting the line height to a size greater than the font size moves it away from the axis edge.
|
@simonbrunel as we look at these line height settings, should we also consider adding settings for the text baseline and alignment or do you think that's too much? |
|
I implemented |
simonbrunel
reviewed
Jun 19, 2017
| @@ -308,7 +308,7 @@ module.exports = function(Chart) { | |||
| var isHorizontal = me.isHorizontal(); | |||
|
|
|||
| var tickFont = parseFontOptions(tickOpts); | |||
| var scaleLabelFontSize = parseFontOptions(scaleLabelOpts).size * 1.5; | |||
| var scaleLabelLineHeight = helpers.getValueOrDefault(scaleLabelOpts.lineHeight, parseFontOptions(scaleLabelOpts).size * 1.5); | |||
There was a problem hiding this comment.
Why font size *1.5 by default?
There was a problem hiding this comment.
I think this was to give some spacing between the bottom of the text and the ticks. I didn't want to change that.
simonbrunel
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text is centered within the line height, so setting the line height to a size greater than the font size moves it away from the axis edge.
Resolves #3562