Add live samples back to docs for each chart type #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Apr 2, 2017
| } | ||
| } | ||
| {% endchartjs %} |
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "child-process-promise": "^2.2.0", | |||
| "coveralls": "^2.11.6", | |||
| "gitbook-cli": "^2.3.0", | |||
| "gitbook-plugin-chartjs": "^0.1.0", | |||
There was a problem hiding this comment.
GitBook dependencies are installed automatically when running gulp docs, so we can remove this line and avoid installing GitBook plugin(s) when not generating the doc.
| { | ||
| "type": "doughnut", | ||
| "data": { | ||
| "labels": [ |
There was a problem hiding this comment.
Could be better for consistency to format the labels array always the same way (inline vs one item per line).
There was a problem hiding this comment.
Agreed, will update that
etimberg
force-pushed
the
documentation-live-charts
branch
from
c740f90 to
1121cbf
Compare
|
Updated per review comments |
simonbrunel
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2068 and #3331
This just adds back the live charts for each type. I didn't add the two column layout for the pie/doughnut charts. Not sure what the best or most sustainable way to do that is.