Fix radar chart position not center #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radar chart position is not center horizontally with v2.5.0. Right and left of `furthestLimits` would be switched wrongly on this refactoring commit. chartjs@e1606f8
shirosaki
force-pushed
the
fix_radar_pos
branch
from
860ec2d to
739d1e0
Compare
|
Good catch @shirosaki! |
|
With v2.5.0: With this fix: |
simonbrunel
approved these changes
Mar 17, 2017
|
@shirosaki looks great. I think this can go in v2.6 😄 |
roicos
pushed a commit
to roicos/Chart.js
that referenced
this pull request
Aug 21, 2017
Radar chart position is not center horizontally with v2.5.0. Right and left of `furthestLimits` would be switched wrongly on this refactoring commit. chartjs@e1606f8
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Radar chart position is not center horizontally with v2.5.0. Right and left of `furthestLimits` would be switched wrongly on this refactoring commit. chartjs@e1606f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radar chart position is not center horizontally with v2.5.0.
Right and left of
furthestLimitswould be switched wrongly onthis refactoring commit.
e1606f8
I've confirmed radar chart is center with this fix.