Parse labels once when building time scale #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Jan 25, 2017
The input labels/data is converted into moments in `determineDataLimits`, reuse them instead of duplicating the work.
tredston
force-pushed
the
feature/parse-once
branch
from
b99b7b1 to
1f6459f
Compare
|
No problem, squashed. |
simonbrunel
reviewed
Jan 25, 2017
| @@ -485,68 +485,4 @@ describe('Time scale tests', function() { | |||
| threshold: 0.75 | |||
| }); | |||
| }); | |||
|
|
|||
| it('should not throw an error if the datasetIndex is out of bounds', function() { | |||
There was a problem hiding this comment.
Why don't we need these tests anymore?
There was a problem hiding this comment.
The method being tested (getLabelMoment) was unused and has been removed.
There was a problem hiding this comment.
I have read only the test title and didn't notice it was explicitly testing this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input labels&data is parsed and converted into moments in
determineDataLimits; reuse these moments inbuildLabelDiffsinstead of duplicating the work.