Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rectRounded point style #3514

Merged
merged 2 commits into from
Nov 26, 2016
Merged

Add rectRounded point style #3514

merged 2 commits into from
Nov 26, 2016

Conversation

cmoel
Copy link
Contributor

@cmoel cmoel commented Oct 25, 2016

Hello! This adds a new point style, rectRounded, and updates the docs that mention the valid values of pointStyle.

@etimberg
Copy link
Member

Changes look good. Can you update https://github.com/chartjs/Chart.js/blob/master/samples/line/point-styles.html as well?

@simonbrunel
Copy link
Member

Shouldn't be roundedRect instead?

@cmoel
Copy link
Contributor Author

cmoel commented Oct 25, 2016

@etimberg Thanks! Will do.

@simonbrunel I originally called it roundedRect but decided to go with rectRounded to stay consistent with rectRot and crossRot (I should have put that in the description... sorry!). That said, I'm happy to change it to roundedRect if that's what you all prefer.

@simonbrunel
Copy link
Member

simonbrunel commented Oct 27, 2016

@cmoel I like consistency, so would certainly have the same approach as you :) I personnaly prefer roundedRect (and roundedRectRot), which seems more standard. @chartjs/maintainers your thoughts?

@etimberg
Copy link
Member

I do agree that roundedRect sounds the best, but rectRounded does match the other options. I don't have a strong preference either way

@etimberg etimberg merged commit 09f30be into chartjs:master Nov 26, 2016
@btahir
Copy link

btahir commented Jul 6, 2022

I am trying to understand the thinking behind this...why would you not give an option to adjust the border radius of a rounded rectangle? It seems it's a hard coded thing and the only way around it is to do a custom canvas object or image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants