Enhance context acquisition on chart creation #3474
Conversation
| me.controller = new Chart.Controller(context, config, me); | ||
|
|
||
| return me.controller; | ||
| var Chart = function(item, config) { |
There was a problem hiding this comment.
I wonder if Chart.Controller can eventually just become the Chart variable. #2481 asked about this and now that everything is in the controller, we might be able to do it.
Only issue I see is with any dependencies that the controller needs but we need the Chart variable to be defined first.
There was a problem hiding this comment.
Agree, Chart.Controller could become Chart (maybe Chart.DatasetController could also simply be Chart.Controller). I can investigate how to do that change and keep backward compatibility but that would be for another PR :)
| message = 'Expected canvas to be an instance of HTMLCanvasElement'; | ||
| } else if (!(chart.ctx instanceof CanvasRenderingContext2D)) { | ||
| message = 'Expected context to be an instance of CanvasRenderingContext2D'; | ||
| } else if (typeof chart.height !== 'number') { |
There was a problem hiding this comment.
Would it be useful to also check if height and width are NaN or is that outside the scope of this?
There was a problem hiding this comment.
You absolutely right, typeof NaN === 'number', actually it should even be a finite number.
Add support for creating a chart from the canvas id and prevent exceptions, at construction time, when the given item doesn't provide a valid CanvasRenderingContext2D or when the getContext API is not accessible (e.g. undefined by add-ons to prevent fingerprinting). New jasmine matcher to verify chart validity.
simonbrunel
force-pushed
the
context-acquisition
branch
from
46365fb to
348b777
Compare
Add support for creating a chart from the canvas id and prevent exceptions, at construction time, when the given item doesn't provide a valid CanvasRenderingContext2D or when the getContext API is not accessible (e.g. undefined by add-ons to prevent fingerprinting). New jasmine matcher to verify chart validity.
Enhances #2807
Replaces #3303