Fix/3061 #3446
Merged
Fix/3061 #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art.Element.transition when the animation finishes to set `_view = _model` caused problems during update because we were using `helpers.extend` all over the place. I changed to code so that we regenerate the model variable rather than continuously extending the old version. I also removed unnecessary tooltip reinitializations from the controller which should improve overall performance during interaction.
…ds properly private
|
Nice work, we finally get this caret fixed, thanks :) |
simonbrunel
reviewed
Oct 8, 2016
| function getTooltipSize(tooltip, model) { | ||
| var ctx = tooltip._chart.ctx; | ||
|
|
||
| var size = { |
There was a problem hiding this comment.
While you are moving code around, I would remove the use of local object to do computations for this:
var height = model.yPadding * 2; // Tooltip Padding
var width = 0;
// ...
height += titleLineCount * titleFontSize;
// ...
return {
height: height,
width: width
};That would help reducing the minified size (height can be minified to h whereas size.height would be s.height).
| */ | ||
| function getBackgroundPoint(vm, size, alignment) { | ||
| // Background Position | ||
| var pt = { |
There was a problem hiding this comment.
Same here: var x = vm.x; var y = vm.y; ... return { x: x, y: y };
simonbrunel
approved these changes
Oct 9, 2016
This was referenced Oct 9, 2016
3 tasks
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Solve weird animation issues with the tooltip. The optimization in Chart.Element.transition when the animation finishes to set `_view = _model` caused problems during update because we were using `helpers.extend` all over the place. I changed to code so that we regenerate the model variable rather than continuously extending the old version. I also removed unnecessary tooltip reinitializations from the controller which should improve overall performance during interaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the weird caret position hover issue described in #3061
I took the opportunity to refactor the private methods and make them correctly private. While I was in the alignment function, I properly used the tooltip alignment options if specified rather than using the auto options.