Version 2.3.0 Release Candidate 1 #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new Travis deploy task to push dist/*.js and bower.json files into tag sources: - requires Travis GITHUB_AUTH_TOKEN and GITHUB_AUTH_EMAIL environment variables - skipped if not built from the "release" branch - release.sh must be executable (see comment) - reads tag version from package.json - fails if tag already exists
Secure values are now read from environment variables defined in the repository settings: https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings
Fix zero border width not working (issue #3241)
Deploy dist files in release tags (bower support)
…le (#3194) Zooming in can cause the params `datasetIndex` and `index` to be null in method `getLabelMoment`. This happens when no ticks are visible on scale. It also throws an error and the chart becomes broken.
Change the linter in gulp tasks to be consistent with Code Climate results which are based on ESLint using .eslintrc options. However, defaults Code Climate rules are too strict, so turn as warnings the 'complexity' and 'max-statements' rules (other errors has been fixed). Note that the Gulp task name has been changed for `gulp lint`.
indent: [error, tab] (http://eslint.org/docs/rules/indent)
curly: [error, all] (http://eslint.org/docs/rules/curly)
This reduces number of calls to momentjs diff() if there are multiple datasets sharing the same labels (#3211).
Previously buildLabelDiffs() was called at the end of buildTicks() and hence labelDiffs cache was calculated twice (in getMinimumBoxSize() and then in fitBox()).
When dealing with time-delineated datasets, often we have data for known
intervals of time. For example, we may have a dataset which represents number
of purchases per day:
```json
{
labels: ['2016-01-01', '2016-01-02', '2016-01-03']
datasets: [
{
data: [12, 87, 42]
}
],
'...': '...'
}
```
In this case, Chart.js will attempt to figure out the best interval to display
the data, and could pick `hours` as the unit. However, in this case, we would
prefer to just use the `days` interval since our data's granularity can not be
represented well with `hours`.
To remedy this, this commit adds the `minUnit` option which allows
users to (optionally) specify what the minimum unit they would like
to use.
ESLint and cleanup
Suport minUnit for time scale
Add "onHover" to the legend options that will hold a user defined function (default is null) and called when a "mousemove" event is registered on top of a label item, with same parameters as the "onClick" option. Also introduced logic that determines if the type of event passed to the legend "handleEvent" function is one we can handle. Currently allowing "click" and "mousemove" events. If the event is not one of those we stop the function execution (this is for the sake of reusing the legend hitbox calculations).
For convenience, charts are now automatically released after each spec if they are not acquired using `persistent: true`. Also remove the confusing and error prone `chartInstance` global variable and make sure that chart instances are local to each spec.
Some tests were using the removed global `chartInstance` variable, so tests values were incorrect since against the wrong chart instance.
Fix an anchor link.
Update 01-Chart-Configuration.md
Remove the existing link which was for Chart.js v1 and add 2 links for Chart.js v2
…rect data for the tooltip
Return correct tooltip data in category scale when double category scale is used
Use '!==' instead of '!='. This fixes eqeqeq error reported by gulp-eslint.
Implement moment diff cache in time scale
ESLint Updates
On Windows, this rule conflicts when running ESLint locally on a repository setup with autoCrlf (then all lines are errors).
Tests cleanup
Fixes a rendering issue when there are multiple datasets on a pie chart and they do not all contain the same number of data in their datasets Fixes #3309
Fix error where pie/doughnut charts did not render correctly with multiple datasets
Thanks to the Bower team, we have been able to register the chart.js package name, previously pointing on a dead repository, which make the Bower integration more consistent with the npm one. All other alias still work (Chart.js, chartjs, Chart-js, chartjs-Chart.js).
|
LGTM 👍 |
|
The published doc seems quite outdated and mentions to use |
|
agreed. hopefully @nnnick can do that ASAP |
panzarino
approved these changes
Sep 17, 2016
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Version 2.3.0 Release Candidate 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting pull request to publish a new release and have most of the @chartjs/maintainers involved in the release process. We can iterate on action items and approve the new release once tasks are done. Merging that PR will (should) trigger the new release (see the release process).
Version:
2.3.0-rc.1Checklist: