Monotone cubic interpolation #3112
Conversation
…ith different interpolation modes on the same graph (updated doc accordingly) - Added new sample file to demonstrate the monotone cubic interpolation mode - Fixed a typo in a comment in updateBezierControlPoints
|
Using the CI to run my unit tests is much too tedious (and slow). I'm going to try to fix my karma errors locally before another commit. |
|
I had to install manually every karma dependency, but I can finally run unit tests. (I don't know why my npm does not process the dependency tree or some such ; that does not seem like the correct behavior. Oh well ...) And it's green (at last) ! |
| var points = (meta.data || []).filter(function(pt) { return !pt._model.skip; }); | ||
| var i, ilen, point, model, controlPoints; | ||
|
|
||
| var needToCap = me.chart.options.elements.line.capBezierPoints; |
There was a problem hiding this comment.
is it right to remove this setting? It's helpful when the graph is zoomed and we want the control points to be allowed to go outside of the drawing area.
There was a problem hiding this comment.
It's not removed, if I've done that right. It is moved after the calls to splineCurve or splineCurveMonotone.
I also think it should be faster this way, because very few JavaScript compilers are able to remove or hoist this needToCap check (thus ASM jump) in the capIfNecessary function (called in the loop). It is also a lot more difficult to avoid/not execute/not compile the loop and call.
capControlPoint should be quite easily inlined by most recent compilers, and the loop can be completely ignored (and even not compiled at all for very recent compilers that do branch pruning). Not that it matters much for loops on < 100 items ^^,
There was a problem hiding this comment.
Right, I missed that the capControlPoint was behind the setting.
You are right that it will probably be a bit faster :)
|
+1 to merge |
| } | ||
| if (!pointBefore || pointBefore.model.skip) pointCurrent.mK = pointCurrent.deltaK; | ||
| else if (!pointAfter || pointAfter.model.skip) pointCurrent.mK = pointBefore.deltaK; | ||
| else if (Math.sign(pointBefore.deltaK) != Math.sign(pointCurrent.deltaK)) pointCurrent.mK = 0; |
There was a problem hiding this comment.
should use helpers.sign to support IE and Safari
There was a problem hiding this comment.
I somehow missed the compatibility table for Math.sign despite having checked Math.EPSILON ... I'll fix that.
…rpolation Monotone cubic interpolation
Implement monotone cubic interpolation (see issue #3086).