Fix tooltip not shown for missing dataset-value #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to merge |
|
+1 |
|
@awallat please rebase so we can merge |
When two datasets are shown and they don't have the same x-coordinates, then the position of the tooltip is not calculated correctly, when using mode 'label' or 'dataset'. This fix checks if the position of every dataset exists, before it is used.
awallat
force-pushed
the
awallat-patch-tooltip-multiple-datasets
branch
from
79ca9ba to
72f423f
Compare
|
I updated my branch and it's free of conflicts now. |
|
Thanks @awallpat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two datasets are shown and one does not have all y-values, because they represent some gaps for example, then the position of the tooltip is not calculated correctly, when using mode 'label' or 'dataset'. For those gaps the y-value is set to 'null', which leads to a problem when calculating the tooltip position. This fix checks if the position of every dataset exists, before it is used.
The problem can be seen in this jsbin:
http://jsbin.com/nefasokosi/edit?html,output