Updated retina scale to allow rendering in IE10 and IE9. #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat doesn't support `window.devicePixelRatio` fixing rendering issues for IE10 and IE9. (issue #1622)
|
Looks good! Thanks @byCedric |
etimberg
added a commit
that referenced
this pull request
Nov 24, 2015
Updated retina scale to allow rendering in IE10 and IE9.
|
Hi guys, After looking and trying many things I fixed the issue for v1 in ie9 for my project. I had some console.log that was making the page not to show the graph until I press F12 in the browser. If that can help anyone with the same scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stored pixel ratio in a variable with a fallback value for browsers that doesn't support
window.devicePixelRatiofixing rendering issues for IE10 and IE9. (issue #1622)The old code referenced
window.devicePixelRatiomultiple times without using fallbacks forundefinedvalues. This resulted in multiply with 0, setting width and height to 0 on old browsers.