review comments

chartjs · Nov 6, 2019 · d6a83bc · d6a83bc
1 parent 6894a6e
commit d6a83bc
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 5 deletions.
diff --git a/src/controllers/controller.bubble.js b/src/controllers/controller.bubble.js
@@ -79,7 +79,10 @@ module.exports = DatasetController.extend({
 		return parsed;
 	},
 
-	getMaxOverflow: function() {
+	/**
+	 * @private
+	 */
+	_getMaxOverflow: function() {
 		var me = this;
 		var meta = me._cachedMeta;
 		var data = meta.data || [];

diff --git a/src/controllers/controller.line.js b/src/controllers/controller.line.js
@@ -164,7 +164,10 @@ module.exports = DatasetController.extend({
 		return values;
 	},
 
-	getMaxOverflow: function() {
+	/**
+	 * @private
+	 */
+	_getMaxOverflow: function() {
 		var me = this;
 		var meta = me._cachedMeta;
 		var data = meta.data || [];

diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js
@@ -603,6 +603,9 @@ helpers.extend(DatasetController.prototype, {
 		return applyStack(stack, value, meta.index);
 	},
 
+	/**
+	 * @private
+	 */
 	_getMinMax: function(scale, canStack) {
 		var chart = this.chart;
 		var meta = this._cachedMeta;
@@ -643,6 +646,9 @@ helpers.extend(DatasetController.prototype, {
 		};
 	},
 
+	/**
+	 * @private
+	 */
 	_getAllParsedValues: function(scale) {
 		var meta = this._cachedMeta;
 		var metaData = meta.data;
@@ -658,6 +664,9 @@ helpers.extend(DatasetController.prototype, {
 		return values;
 	},
 
+	/**
+	 * @private
+	 */
 	_cacheScaleStackStatus: function() {
 		var me = this;
 		var indexScale = me._getIndexScale();
@@ -669,6 +678,9 @@ helpers.extend(DatasetController.prototype, {
 		}
 	},
 
+	/**
+	 * @private
+	 */
 	_scaleCheck: function() {
 		var me = this;
 		var indexScale = me._getIndexScale();
@@ -681,7 +693,10 @@ helpers.extend(DatasetController.prototype, {
 			cache[valueScale.id] !== valueScale.options.stacked;
 	},
 
-	getMaxOverflow: function() {
+	/**
+	 * @private
+	 */
+	_getMaxOverflow: function() {
 		return false;
 	},
 
@@ -690,7 +705,7 @@ helpers.extend(DatasetController.prototype, {
 		me._configure();
 		me._cachedDataOpts = null;
 		me.update(reset);
-		me._cachedMeta._clip = toClip(helpers.valueOrDefault(me._config.clip, defaultClip(me._xScale, me._yScale, me.getMaxOverflow())));
+		me._cachedMeta._clip = toClip(helpers.valueOrDefault(me._config.clip, defaultClip(me._xScale, me._yScale, me._getMaxOverflow())));
 		me._cacheScaleStackStatus();
 	},
 

diff --git a/src/elements/element.point.js b/src/elements/element.point.js
@@ -58,7 +58,6 @@ module.exports = Element.extend({
 		var radius = vm.radius || 0;
 		var borderWidth = vm.borderWidth || 0;
 		return (radius + borderWidth) * 2;
-
 	},
 
 	tooltipPosition: function() {