Backward compatible default fill for radar charts (#6655)

* Backward compatible fill behavior for radar
chartjs · Nov 2, 2019 · 1cce8a5 · 1cce8a5
1 parent a920bfe
commit 1cce8a5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/src/controllers/controller.radar.js b/src/controllers/controller.radar.js
@@ -14,6 +14,7 @@ defaults._set('radar', {
 	},
 	elements: {
 		line: {
+			fill: 'start',
 			tension: 0 // no bezier in radar
 		}
 	}

diff --git a/test/fixtures/controller.radar/backgroundColor/scriptable.js b/test/fixtures/controller.radar/backgroundColor/scriptable.js
@@ -25,6 +25,7 @@ module.exports = {
 			title: false,
 			elements: {
 				line: {
+					fill: true,
 					backgroundColor: function(ctx) {
 						var index = (ctx.dataIndex === undefined ? ctx.datasetIndex : ctx.dataIndex);
 						return index === 0 ? '#ff0000'

diff --git a/test/fixtures/controller.radar/backgroundColor/value.js b/test/fixtures/controller.radar/backgroundColor/value.js
@@ -20,6 +20,7 @@ module.exports = {
 			title: false,
 			elements: {
 				line: {
+					fill: true,
 					backgroundColor: '#00ff00'
 				},
 				point: {

diff --git a/test/fixtures/controller.radar/borderDash/scriptable.js b/test/fixtures/controller.radar/borderDash/scriptable.js
@@ -22,6 +22,7 @@ module.exports = {
 			title: false,
 			elements: {
 				line: {
+					fill: true,
 					borderColor: '#00ff00',
 					borderDash: function(ctx) {
 						return ctx.datasetIndex === 0 ? [5] : [10];
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,7 @@ defaults._set('radar', { @@
     	},
     	elements: {
     		line: {
+    			fill: 'start',
     			tension: 0 // no bezier in radar
     		}
     	}
@@ Expand Down @@