Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Stream Setup Working? #3867

Draft
wants to merge 8 commits into
base: mat/streaming
Choose a base branch
from
Draft

Initial Stream Setup Working? #3867

wants to merge 8 commits into from
+991 −230

Conversation

mjacob1002
Copy link
Contributor

@mjacob1002 mjacob1002 commented Feb 3, 2025 •
edited
Loading

TODO:

  • Clean up the debugging code and make sure the variable names actually correspond with what the variable is supposed to represent.
  • Update the doc with the protocol and make it detailed for sends, receives, and closing of streams. Specifically make sure we take care of all code paths, mainly what happens when the stream is closed and there are buffered get requests and alike.

mjacob1002 and others added 6 commits February 1, 2025 02:58
@mjacob1002
Overhauling the codebase a little bit. Have to finish reimplementing …
512e53d 
…the get functionality, as well as the protocol for closing streams.
@mjacob1002
checkpoint 2. no testing happened yet, but we have to still implement…
1df91e7 
… some logic when we register a new PE
@zhuangy47
fixed some syntax errors
1a28857
@mjacob1002
still debugging this nonsense. The global starter chare seems to be a…
6d60861 
…ble to get all the sent bytes accurately (although in the logs sometimes it seems to hit hte reduction twice, which is concerning...
@mjacob1002
program still deadlocks a little bit with 10 producers, 2 consuemrs. …
53e1f01 
…Should investigate why...
@mjacob1002
I think it works now? But have to drastically clean up the code.
b296ddb
@mjacob1002 mjacob1002 requested a review from zhuangy47 February 3, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuangy47 zhuangy47 Awaiting requested review from zhuangy47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjacob1002 @zhuangy47