Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check channel boundaries before checking out charm code #1465

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

addyess
Copy link
Member

@addyess addyess commented Dec 14, 2023

tigera-secure-ee charm should not be built beyond the 1.28 release branch, and if queued for building during 1.29/beta, it should be skipped over due to its channel boundaries settings.

This code will check the channel-boundaries and only build if there is a channel for a charm to be published to based on the channel boundaries

Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateoflorido mateoflorido merged commit 054e361 into main Dec 14, 2023
6 checks passed
@mateoflorido mateoflorido deleted the akd/charm-build/check-channel-boundaries branch December 14, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants