let lp builders infer the snap series from snapcraft.yaml #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynerva
pushed a commit
that referenced
this pull request
Feb 16, 2023
Cynerva
added a commit
that referenced
this pull request
Feb 16, 2023
Cynerva
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our snap recipes have
xenialset as the distro series (example). While this doesn't seem to have any effect on the contents of the snap, it is confusing to see 'xenial' when looking through the snap recipes of our core18/core20 snaps.According to the lp snap.new api,
distro_seriesis optional and will be inferred from snapcraft.yaml. Let's let that happen for future k8s versions (existing snap recipes will remain as they are).