Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include encryption_at_rest path #16

Merged
merged 2 commits into from
May 29, 2024
Merged

include encryption_at_rest path #16

merged 2 commits into from
May 29, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented May 29, 2024 •
edited
Loading

Adds encryption_config_path to the module to set the encryption of etcd secrets configuration

@addyess addyess mentioned this pull request May 29, 2024
Merged
@addyess addyess requested a review from mateoflorido May 29, 2024 14:09
@addyess
Copy link
Member Author

addyess commented May 29, 2024

Will need to be backported to release_1.29 and release_1.30

mateoflorido
mateoflorido previously approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess requested a review from mateoflorido May 29, 2024 19:20
mateoflorido
mateoflorido approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit 03a2ad3 into main May 29, 2024
6 checks passed
@addyess addyess deleted the KU-510/vault-kv/encryption-at-rest branch May 29, 2024 19:46
addyess added a commit that referenced this pull request May 29, 2024
@addyess
Cherry-pick #16 via PR into release_1.29
c64f73b
@addyess addyess mentioned this pull request May 29, 2024
Merged
addyess added a commit that referenced this pull request May 29, 2024
@addyess
Cherry-pick #16 via PR into release_1.29 (#17)
7a5d5e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @mateoflorido