Update charm to update the root kubeconfig with a current CA #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
Jun 20, 2024
addyess
commented
Jun 20, 2024
addyess
commented
Jun 20, 2024
Comment on lines
+72
to
+75
| f"Command failed: {command}\n" | ||
| f"returncode: {e.returncode}\n" | ||
| f"stdout: {e.stdout.decode()}\n" | ||
| f"stderr: {e.stderr.decode()}\n" |
There was a problem hiding this comment.
Extra debug on kubectl calls to print the stderr to the error log
kwmonroe
approved these changes
Jun 21, 2024
addyess
added a commit
that referenced
this pull request
Jun 21, 2024
* Update charm to update the root kubeconfig with a current CA * Use updated main branch of kubernetes-snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Each config hook should do it's best to update the root kubeconfig to have a valid ca cert.
Details
According to the bug LP#2064305, the charm code couldn't connect to the control-plane because
This can be caused by the CA being invalid on the next charm hook. This PR addresses the issue by ensuring the CA cert is correct on each possible reconcile loop
Draft until the following is merged