Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that containerd config toml generates under integration tests #58

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

addyess
Copy link
Member

@addyess addyess commented Nov 2, 2021

Updates integration tests to inspect the containerd config pre and post addition of a second container registry.

@addyess
Copy link
Member Author

addyess commented Nov 2, 2021

Local Integration results -- (if the github actions doesn't function b/c of issues with kubernetes-master charm)
https://paste.ubuntu.com/p/Z4FsZK5XCJ/

@Cynerva
Copy link
Contributor

Cynerva commented Nov 3, 2021

Local Integration results -- (if the github actions doesn't function b/c of issues with kubernetes-master charm)
https://paste.ubuntu.com/p/Z4FsZK5XCJ/

I see hook errors on kubernetes-master and docker-registry in your output. Any idea what's going on there?

@@ -7,7 +7,7 @@ machines:
'1':
constraints: cores=4 mem=4G root-disk=16G
series: {{ series }}
applications:
services:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

services in bundles is deprecated. This should stay as applications.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i saw this in "charmed-kubernetes-master" (https://github.com/charmed-kubernetes/charm-kubernetes-master/blob/master/tests/data/bundle.yaml#L10). Will revert as applications is preferred

@addyess addyess requested a review from Cynerva November 5, 2021 16:25
@addyess
Copy link
Member Author

addyess commented Nov 10, 2021

I filed LP#1950501 on docker-registry
And raised canonical/docker-registry-charm#50

@addyess
Copy link
Member Author

addyess commented Nov 10, 2021

I've updated the integration test results here although they are passing in CI too

@Cynerva Cynerva merged commit 184dc32 into master Nov 10, 2021
@Cynerva Cynerva deleted the int/config-render branch November 10, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants