-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that containerd config toml generates under integration tests #58
Conversation
d5df382
to
603d593
Compare
Local Integration results -- (if the github actions doesn't function b/c of issues with kubernetes-master charm) |
I see hook errors on kubernetes-master and docker-registry in your output. Any idea what's going on there? |
tests/data/bundle.yaml
Outdated
@@ -7,7 +7,7 @@ machines: | |||
'1': | |||
constraints: cores=4 mem=4G root-disk=16G | |||
series: {{ series }} | |||
applications: | |||
services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
services
in bundles is deprecated. This should stay as applications
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i saw this in "charmed-kubernetes-master" (https://github.com/charmed-kubernetes/charm-kubernetes-master/blob/master/tests/data/bundle.yaml#L10). Will revert as applications
is preferred
I filed LP#1950501 on docker-registry |
I've updated the integration test results here although they are passing in CI too |
Updates integration tests to inspect the containerd config pre and post addition of a second container registry.