-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds optional addons for microk8s #46
Conversation
In order to be able to use the nginx-ingress-integrator charm and other related charms, we need to enable ingress in microk8s. This adds the microk8s-addons option, which will contain the addons to be enabled in microk8s. If not given, the default addons will be added instead (storage, dns, rbac).
- Updated Readme with more info - Added extra tests
#45 includes a few conversations about design decisions, so reviewing the conversations there will help with understanding this PR. |
Seems like the test failed for 2 separate reasons - the first test failed because the call |
oh interesting, so in (most?) cases doing |
- This implies that other addons may be enabled by default. - Updated README to indicate that a minimum set of addons are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only minor security concerns. Otherwise LGTM
This PR replaces #45, which itself extended #33. The PR originates from @kian99 who does not have permissions in this repo, so the full CI suite cannot be executed. I'm opening this clone of @kian99's PR so we can get the full test suite.
Copied from #45:
Fixes #32