Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add channel arguments to snaps in the action #28

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Conversation

ca-scribner
Copy link
Contributor

@ca-scribner ca-scribner commented Nov 12, 2021

resolves #27

@ca-scribner
Copy link
Contributor Author

I see the other channel args were left as default_value=null and then use if statements. I ended up using default=latest/stable so all calls could be snap install ... --channel=${this_channel} to avoid a few extra lines, but I can change it to match the current format if that's preferred.

@ca-scribner ca-scribner requested a review from johnsca November 12, 2021 21:37
Copy link
Contributor

@johnsca johnsca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comment below, you also need to run npm run build. There's a pre-commit hook in the repo under .github/hooks/pre-commit that I recommend you symlink into your .git/hooks/ directory to catch that.

Also, the PR probably doesn't need to be a draft anymore.

@ca-scribner ca-scribner marked this pull request as ready for review November 15, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow for setting snap channels of all auto-installed snaps
3 participants