-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Tox at system level #12
Conversation
dc02431
to
96ffc15
Compare
Any idea what's up with the failing microk8s and microstack tests? Are they expected to fail right now? It looks like they're unrelated to the changes in this PR but I have no idea what's going on. |
Not all runners will have `~/.local/bin` on the PATH by default, so Tox should be installed at the system level.
ba7aced
to
e673f54
Compare
…nup to avoid timeouts
80bd723
to
0f4af60
Compare
af45e5d
to
7117295
Compare
…rce does not exist yet
cbbebaf
to
96d28b9
Compare
3099181
to
2aef5d3
Compare
Even though the microstack case is still failing, since it's used less than LXD or microk8s, I'd like to get this merged and those fixed and merged and we can work on the microstack issue going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe add a basic pytest-operator test to the testing actions which builds and deploys some charm with charmcraft? This might help with some of these issues in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to run an action with this branch I get the following error:
/usr/bin/bash -c sudo usermod -a -G microk8s $USER
/usr/bin/sg microk8s -c scripts/microk8s-init.sh
sh: 1: scripts/microk8s-init.sh: not found
Error: The process '/usr/bin/sg' failed with exit code 127
Besides, b12e61c added new conditions for branch main, and yet main is not even exist in this repository. As result pull requests to master will never trigger CI. |
2fc0693
to
c5e13d8
Compare
Hi, thank you for picking this up. But actually deleting master branch fails all existing downstream projects, if any. I think maybe we'd prefer a more considerate way, taking advantages of revisions, to prevent breaking people's projects unsolicitedly. After all, this project is meant for wide use, isn't it? |
Not all runners will have
~/.local/bin
on the PATH by default, so Tox should be installed at the system level.