Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Tox at system level #12

Merged
merged 21 commits into from
Aug 20, 2021
Merged

Install Tox at system level #12

merged 21 commits into from
Aug 20, 2021

Conversation

johnsca
Copy link
Contributor

@johnsca johnsca commented Jun 30, 2021

Not all runners will have ~/.local/bin on the PATH by default, so Tox should be installed at the system level.

@johnsca johnsca force-pushed the johnsca/tox-as-global branch 2 times, most recently from dc02431 to 96ffc15 Compare July 1, 2021 18:46
@Cynerva
Copy link

Cynerva commented Jul 13, 2021

Any idea what's up with the failing microk8s and microstack tests? Are they expected to fail right now? It looks like they're unrelated to the changes in this PR but I have no idea what's going on.

johnsca added 3 commits July 19, 2021 13:51
Not all runners will have `~/.local/bin` on the PATH by default, so Tox
should be installed at the system level.
@johnsca johnsca force-pushed the johnsca/tox-as-global branch from ba7aced to e673f54 Compare July 19, 2021 17:51
@johnsca johnsca force-pushed the johnsca/tox-as-global branch from 80bd723 to 0f4af60 Compare July 21, 2021 15:59
@johnsca johnsca force-pushed the johnsca/tox-as-global branch from af45e5d to 7117295 Compare August 4, 2021 20:36
@johnsca johnsca force-pushed the johnsca/tox-as-global branch from cbbebaf to 96d28b9 Compare August 16, 2021 16:03
@johnsca johnsca force-pushed the johnsca/tox-as-global branch from 3099181 to 2aef5d3 Compare August 18, 2021 15:47
@johnsca
Copy link
Contributor Author

johnsca commented Aug 19, 2021

Even though the microstack case is still failing, since it's used less than LXD or microk8s, I'd like to get this merged and those fixed and merged and we can work on the microstack issue going forward.

Copy link
Contributor

@DomFleischmann DomFleischmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a basic pytest-operator test to the testing actions which builds and deploys some charm with charmcraft? This might help with some of these issues in the future.

Copy link
Contributor

@DomFleischmann DomFleischmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to run an action with this branch I get the following error:

  /usr/bin/bash -c sudo usermod -a -G microk8s $USER
  /usr/bin/sg microk8s -c scripts/microk8s-init.sh
  sh: 1: scripts/microk8s-init.sh: not found
  Error: The process '/usr/bin/sg' failed with exit code 127

@vicamo
Copy link

vicamo commented Aug 20, 2021

Besides, b12e61c added new conditions for branch main, and yet main is not even exist in this repository. As result pull requests to master will never trigger CI.

@johnsca
Copy link
Contributor Author

johnsca commented Aug 20, 2021

@vicamo Thanks, I meant to rename the primary branch and missed that. Fixed now.

Edit: Actually, e673f54 was also included as a stop-gap, but not reason to not go ahead and do the rename.

@johnsca johnsca force-pushed the johnsca/tox-as-global branch from 2fc0693 to c5e13d8 Compare August 20, 2021 15:22
@johnsca johnsca merged commit cf7a4a9 into main Aug 20, 2021
@vicamo
Copy link

vicamo commented Aug 24, 2021

@vicamo Thanks, I meant to rename the primary branch and missed that. Fixed now.

Edit: Actually, e673f54 was also included as a stop-gap, but not reason to not go ahead and do the rename.

Hi, thank you for picking this up. But actually deleting master branch fails all existing downstream projects, if any. I think maybe we'd prefer a more considerate way, taking advantages of revisions, to prevent breaking people's projects unsolicitedly. After all, this project is meant for wide use, isn't it?

@addyess addyess deleted the johnsca/tox-as-global branch February 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants