-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optionally pull config from a custom file (envvar), default to data path. #557
Conversation
Hey, I'm no maintainer here but it would be great if the new environment variable would be also documented somehow in the readme of the project. Maybe you can add it there? :) |
are there any updates on this? |
ping @aymanbagabas |
Hey @fire833, could you add tests for these changes? |
Let me know what you think of those tests. |
ping @aymanbagabas |
1 similar comment
ping @aymanbagabas |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 51.96% 53.01% +1.05%
==========================================
Files 157 159 +2
Lines 13454 11555 -1899
==========================================
- Hits 6991 6126 -865
+ Misses 5891 4860 -1031
+ Partials 572 569 -3 ☔ View full report in Codecov by Sentry. |
@fire833 Thank you so much! |
This PR is related to #553, it simply gives the option to override the config location with the SOFT_SERVE_CONFIG_LOCATION (and checks that a file exists there), otherwise defaults to looking in the config path. Let me know if you have any comments or concerns.