Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optionally pull config from a custom file (envvar), default to data path. #557

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

fire833
Copy link
Contributor

@fire833 fire833 commented Aug 11, 2024

This PR is related to #553, it simply gives the option to override the config location with the SOFT_SERVE_CONFIG_LOCATION (and checks that a file exists there), otherwise defaults to looking in the config path. Let me know if you have any comments or concerns.

@fire833 fire833 requested a review from aymanbagabas as a code owner August 11, 2024 03:14
@rubenhoenle
Copy link
Contributor

Hey, I'm no maintainer here but it would be great if the new environment variable would be also documented somehow in the readme of the project. Maybe you can add it there? :)

@fire833
Copy link
Contributor Author

fire833 commented Aug 28, 2024

are there any updates on this?

@rubenhoenle
Copy link
Contributor

ping @aymanbagabas

@aymanbagabas
Copy link
Member

Hey @fire833, could you add tests for these changes?

@fire833
Copy link
Contributor Author

fire833 commented Aug 30, 2024

Let me know what you think of those tests.

@fire833
Copy link
Contributor Author

fire833 commented Aug 30, 2024

ping @aymanbagabas

1 similar comment
@fire833
Copy link
Contributor Author

fire833 commented Sep 6, 2024

ping @aymanbagabas

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (b06b555) to head (3e1b73b).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   51.96%   53.01%   +1.05%     
==========================================
  Files         157      159       +2     
  Lines       13454    11555    -1899     
==========================================
- Hits         6991     6126     -865     
+ Misses       5891     4860    -1031     
+ Partials      572      569       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aymanbagabas aymanbagabas merged commit c354d5f into charmbracelet:main Sep 9, 2024
11 checks passed
@aymanbagabas
Copy link
Member

@fire833 Thank you so much!

aymanbagabas added a commit that referenced this pull request Dec 9, 2024
Fixes: c354d5f (feat: optionally pull config from a custom file (envvar), default to data path. (#557))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants