Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graceful shutdown #54

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix: graceful shutdown #54

merged 1 commit into from
Jan 11, 2022

Conversation

caarlos0
Copy link
Member

gracefully shutdown server

Signed-off-by: Carlos A Becker <[email protected]>
Copy link
Contributor

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If I remember correctly the important bit here is to give the signal channel a capacity of 1, so well done :)

@github-actions
Copy link

Download the artifacts for this pull request:

Or use the following Docker image ghcr.io/charmbracelet/soft-serve:devel-7cca2bc

@caarlos0 caarlos0 merged commit 33176d0 into main Jan 11, 2022
@caarlos0 caarlos0 deleted the shutdown branch January 11, 2022 17:49
aymanbagabas added a commit to charmbracelet/charm that referenced this pull request Jan 28, 2022
aymanbagabas added a commit to charmbracelet/charm that referenced this pull request Jan 28, 2022
aymanbagabas added a commit to charmbracelet/charm that referenced this pull request Jan 28, 2022
aymanbagabas added a commit to charmbracelet/charm that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants