Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid duplicated CI runs #433

Merged
merged 1 commit into from
Nov 30, 2023
Merged

build: avoid duplicated CI runs #433

merged 1 commit into from
Nov 30, 2023

Conversation

caarlos0
Copy link
Member

running on both push and pull_request end up running the same job twice for a push on a PR, which waste our CI minutes.

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 3823 lines in your changes are missing coverage. Please review.

Comparison is base (050a0d1) 50.52% compared to head (aeb33df) 47.77%.
Report is 94 commits behind head on main.

❗ Current head aeb33df differs from pull request most recent head 6264003. Consider uploading reports for the commit 6264003 to get more accurate results

Files Patch % Lines
pkg/web/git_lfs.go 25.15% 574 Missing and 27 partials ⚠️
pkg/git/lfs.go 1.98% 297 Missing ⚠️
pkg/ui/pages/repo/stash.go 0.00% 185 Missing ⚠️
pkg/backend/webhooks.go 17.82% 162 Missing and 4 partials ⚠️
pkg/ssh/cmd/webhooks.go 45.90% 156 Missing and 9 partials ⚠️
pkg/ui/pages/repo/files.go 5.00% 152 Missing ⚠️
pkg/lfs/http_client.go 5.92% 127 Missing ⚠️
pkg/ui/pages/repo/refsitem.go 5.38% 123 Missing ⚠️
pkg/backend/repo.go 40.59% 93 Missing and 27 partials ⚠️
pkg/store/database/lfs.go 22.05% 105 Missing and 1 partial ⚠️
... and 82 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   50.52%   47.77%   -2.76%     
==========================================
  Files         107      154      +47     
  Lines        8209    13068    +4859     
==========================================
+ Hits         4148     6243    +2095     
- Misses       3767     6337    +2570     
- Partials      294      488     +194     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aymanbagabas aymanbagabas merged commit bac2ff3 into main Nov 30, 2023
7 of 9 checks passed
@aymanbagabas aymanbagabas deleted the ci branch November 30, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants