Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor,fix: add rename lfs objects migration #409

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Oct 27, 2023

Rename lfs objects from OID[:2]/OID[2:4]/OID[4:] to OID[:2]/OID[2:4]/OID to follow specs https://github.com/git-lfs/git-lfs/blob/main/docs/spec.md#intercepting-git

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 3824 lines in your changes are missing coverage. Please review.

Comparison is base (050a0d1) 50.52% compared to head (840417d) 47.66%.
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   50.52%   47.66%   -2.87%     
==========================================
  Files         107      154      +47     
  Lines        8209    13044    +4835     
==========================================
+ Hits         4148     6218    +2070     
- Misses       3767     6338    +2571     
- Partials      294      488     +194     
Files Coverage Δ
git/commit.go 42.85% <100.00%> (+17.85%) ⬆️
git/reference.go 40.00% <100.00%> (+7.85%) ⬆️
pkg/backend/backend.go 100.00% <100.00%> (ø)
pkg/backend/cache.go 68.75% <ø> (ø)
pkg/backend/context.go 85.71% <ø> (ø)
pkg/backend/settings.go 78.57% <ø> (ø)
pkg/config/config.go 80.87% <100.00%> (ø)
pkg/config/file.go 100.00% <ø> (ø)
pkg/config/ssh.go 100.00% <100.00%> (ø)
pkg/cron/cron.go 90.00% <100.00%> (ø)
... and 141 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aymanbagabas aymanbagabas requested a review from caarlos0 October 27, 2023 19:35
Base automatically changed from pkg to main October 27, 2023 21:26
@aymanbagabas aymanbagabas merged commit f915f4d into main Oct 31, 2023
18 of 19 checks passed
@aymanbagabas aymanbagabas deleted the migrate-lfs-objs branch October 31, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant