Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add git remotes tab #397

Conversation

emilaleksanteri
Copy link

Complete TODO: Add Git remotes tab #369

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5e233b5) 50.10% compared to head (a2b392f) 50.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           browse     #397      +/-   ##
==========================================
+ Coverage   50.10%   50.13%   +0.03%     
==========================================
  Files         134      134              
  Lines       11491    11498       +7     
==========================================
+ Hits         5757     5765       +8     
  Misses       5294     5294              
+ Partials      440      439       -1     
Files Coverage Δ
git/reference.go 30.76% <0.00%> (-9.24%) ⬇️
server/ui/pages/repo/refs.go 18.13% <0.00%> (-0.92%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @emilaleksanteri, thanks for the PR. This is an oversimplified solution. I think the remotes tab should have each remote act like a directory where you can browse remote branches.

@emilaleksanteri
Copy link
Author

Hi @emilaleksanteri, thanks for the PR. This is an oversimplified solution. I think the remotes tab should have each remote act like a directory where you can browse remote branches.

@aymanbagabas so instead of browsing the remotes content on via the existing files and commits tabs etc, have its own thing for those or?

@aymanbagabas
Copy link
Member

@aymanbagabas so instead of browsing the remotes content on via the existing files and commits tabs etc, have its own thing for those or?

So instead of listing all the remote branches in one list, use a tree-like structure to browse remote branches. Similar to what Lazygit offers.
image

@emilaleksanteri
Copy link
Author

@aymanbagabas so instead of browsing the remotes content on via the existing files and commits tabs etc, have its own thing for those or?

So instead of listing all the remote branches in one list, use a tree-like structure to browse remote branches. Similar to what Lazygit offers. image

@aymanbagabas ooh okay, that's really cool, I'll add it to the remote branch feature!

@aymanbagabas aymanbagabas deleted the branch charmbracelet:browse October 25, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants