Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh): add authentication middleware #388

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

aymanbagabas
Copy link
Member

We need to verify that the key used to establish the connection is the same key used for authentication, otherwise, refuse connection.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 2054 lines in your changes are missing coverage. Please review.

Comparison is base (050a0d1) 50.52% compared to head (9b6a761) 50.36%.
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   50.52%   50.36%   -0.17%     
==========================================
  Files         107      133      +26     
  Lines        8209    11321    +3112     
==========================================
+ Hits         4148     5702    +1554     
- Misses       3767     5179    +1412     
- Partials      294      440     +146     
Files Coverage Δ
git/repo.go 50.69% <ø> (+6.71%) ⬆️
server/backend/backend.go 100.00% <100.00%> (ø)
server/backend/collab.go 86.66% <100.00%> (+0.95%) ⬆️
server/config/config.go 80.66% <100.00%> (+0.66%) ⬆️
server/config/file.go 100.00% <ø> (ø)
server/config/ssh.go 100.00% <100.00%> (ø)
server/cron/cron.go 90.00% <100.00%> (+30.00%) ⬆️
server/db/context.go 85.71% <100.00%> (ø)
server/db/db.go 43.90% <ø> (ø)
server/db/errors.go 31.57% <ø> (ø)
... and 69 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We need to verify that the key used to establish the connection is the
same key used for authentication, otherwise, refuse connection.
@aymanbagabas aymanbagabas merged commit 407c4ec into main Sep 27, 2023
17 of 19 checks passed
@aymanbagabas aymanbagabas deleted the auth-middleware branch September 27, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public key authentication bypass despite client-side keypair authn failure when allow-keyless is true
2 participants