Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): quote postgres keywords #383

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix(db): quote postgres keywords #383

merged 1 commit into from
Sep 13, 2023

Conversation

aymanbagabas
Copy link
Member

The keyword "key" is a reserved word in Postgres and must be quoted if used as a column name.

Fixes: #380

The keyword "key" is a reserved word in Postgres and must be quoted if
used as a column name.

Fixes: #380
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 45.16% and project coverage change: -0.19% ⚠️

Comparison is base (050a0d1) 50.52% compared to head (da59faf) 50.34%.
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   50.52%   50.34%   -0.19%     
==========================================
  Files         107      133      +26     
  Lines        8209    11265    +3056     
==========================================
+ Hits         4148     5671    +1523     
- Misses       3767     5157    +1390     
- Partials      294      437     +143     
Files Changed Coverage Δ
git/repo.go 50.69% <ø> (+6.71%) ⬆️
server/access/access.go 64.70% <0.00%> (-26.97%) ⬇️
server/backend/hooks.go 0.00% <0.00%> (ø)
server/config/context.go 85.71% <0.00%> (ø)
server/config/file.go 100.00% <ø> (ø)
server/daemon/daemon.go 49.76% <0.00%> (+3.03%) ⬆️
server/db/errors.go 31.57% <ø> (ø)
server/db/logger.go 37.31% <0.00%> (+12.31%) ⬆️
server/db/migrate/migrate.go 32.53% <0.00%> (ø)
server/git/git.go 31.66% <ø> (+5.00%) ⬆️
... and 68 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aymanbagabas aymanbagabas merged commit 6a42d89 into main Sep 13, 2023
@aymanbagabas aymanbagabas deleted the pg-keyword branch September 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use settings commands due to missing PostgreSQL columns
2 participants