-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement database module and abstract backend #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aymanbagabas
commented
Jul 12, 2023
•
edited
Loading
edited
- Separate database sql logic from backend
- Add database migrations support
- Add Postgres support
- Add database models
- Make the backend module concrete
- Tidy modules and clean up unused code
aymanbagabas
changed the title
refactor: implement database module
refactor: implement database module and abstract backend
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 46.33% 50.70% +4.37%
==========================================
Files 88 107 +19
Lines 7753 8179 +426
==========================================
+ Hits 3592 4147 +555
+ Misses 3879 3746 -133
- Partials 282 286 +4
|
Prepare for multi database driver support
Reference: #331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.