Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement database module and abstract backend #337

Merged
merged 27 commits into from
Jul 17, 2023
Merged

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Jul 12, 2023

  • Separate database sql logic from backend
  • Add database migrations support
  • Add Postgres support
  • Add database models
  • Make the backend module concrete
  • Tidy modules and clean up unused code

@aymanbagabas aymanbagabas requested a review from caarlos0 July 12, 2023 17:10
@aymanbagabas aymanbagabas changed the title refactor: implement database module refactor: implement database module and abstract backend Jul 12, 2023
@aymanbagabas aymanbagabas marked this pull request as draft July 12, 2023 17:22
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #337 (f339f2b) into main (7cd0583) will increase coverage by 4.37%.
The diff coverage is 60.69%.

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   46.33%   50.70%   +4.37%     
==========================================
  Files          88      107      +19     
  Lines        7753     8179     +426     
==========================================
+ Hits         3592     4147     +555     
+ Misses       3879     3746     -133     
- Partials      282      286       +4     
Impacted Files Coverage Δ
git/commit.go 25.00% <ø> (ø)
git/patch.go 56.33% <0.00%> (+56.33%) ⬆️
server/access/access.go 91.66% <ø> (ø)
server/backend/hooks.go 0.00% <0.00%> (ø)
server/backend/utils.go 0.00% <0.00%> (ø)
server/config/file.go 100.00% <ø> (ø)
server/stats/stats.go 90.90% <ø> (ø)
server/sync/workqueue.go 50.00% <ø> (ø)
server/ui/common/utils.go 0.00% <0.00%> (ø)
server/ui/components/code/code.go 25.16% <0.00%> (+0.32%) ⬆️
... and 78 more

... and 1 file with indirect coverage changes

@aymanbagabas aymanbagabas marked this pull request as ready for review July 13, 2023 18:47
@aymanbagabas aymanbagabas merged commit e398b4d into main Jul 17, 2023
@aymanbagabas aymanbagabas deleted the db branch July 17, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant