Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Private Value not honored by TUI menu #81

Closed
grondinm opened this issue Jan 27, 2022 · 1 comment · Fixed by #117 or #123
Closed

Config Private Value not honored by TUI menu #81

grondinm opened this issue Jan 27, 2022 · 1 comment · Fixed by #117 or #123

Comments

@grondinm
Copy link

Hello,

First off I love this project. Just starting to use it and plan on moving all my personal Git repos to it. One thing I'm running into during my initial test setup is that the Private config option does not seem to be honored. I have this in my config

repos:
   - name: Welcome
     repo: Welcome
     private: false
     note: "Welcome Page"
   - name: Settings
     repo: config
     private: true
     note: "Configuration and content repo for this server"

but when I connect without Auth the Settings repo still shows up in the menu. Am I misunderstanding something? Sorry if I missed something obvious. I'm just connecting locally for now.
@grondinm grondinm changed the title Config Private Value not honored Config Private Value not honored by TUI menu Jan 27, 2022
@jackwilsdon
Copy link

jackwilsdon commented Feb 4, 2022 •
edited
Loading

It looks like the private flag is ignored for the config repo:

soft-serve/internal/tui/commands.go

Line 65 in bdee7eb

if acc == gm.NoAccess && cr.Repo != "config" {

@aymanbagabas aymanbagabas mentioned this issue Jun 15, 2022
Merged
aymanbagabas added a commit that referenced this issue Jun 15, 2022
@aymanbagabas
fix: respect private repos
b2b37a2 
only display private repos for users with read access

Fixes: #81
@aymanbagabas aymanbagabas mentioned this issue Jun 15, 2022
Merged
aymanbagabas added a commit that referenced this issue Jun 15, 2022
@aymanbagabas
fix: respect private repos
cb60bc0 
only display private repos for users with read access

Fixes: #81
aymanbagabas added a commit that referenced this issue Jun 15, 2022
@aymanbagabas
fix: respect private repos
a679676 
Fixes: #81
aymanbagabas added a commit that referenced this issue Jun 15, 2022
@aymanbagabas
fix: respect private repos
4a5c387 
only display private repos for users with read access

Fixes: #81
aymanbagabas added a commit that referenced this issue Jun 21, 2022
@aymanbagabas
fix: respect private repos
52481ab 
Fixes: #81
aymanbagabas added a commit that referenced this issue Jun 21, 2022
@aymanbagabas
feat(ui): new tui
ffaa007 
wip: new ui

wip: selector

wip: header & footer

wip: selection readme

wip: add readme

wip: copy text

wip: fix readme wrap

wip: fix errorview margin

wip: underline filtered items

wip: add selector mouse wheel support

wip: fix reset formatting on line wraps

wip: initial repo ui implementation

wip: repo header

go mod tidy

add git branch symbol

fix: selector keymap

feat: display repo commits

feat: display commit diffs

godox

fix config tests

feat: render error in app style

feat: repo files tab

feat: add refs component

fix: glitches & add refs statusbar

feat: add full help toggle

fix: error view height

wip

init ui and check for errors

fix: initial repo

fix: url style

fix: selecting repo

feat: new log item style

feat: copy over ssh

clean

feat: detect private repos

feat: indicate private repos via emoji

feat: only show private repos for admins

feat: add files content line number

fix: bold selected file size

fix: remove header from repo page

fix: comitter & authored name highlight

fix: repo last updated time

feat: add statusbar symbols

fix: no repos

fix: prevent tab out of bound error

fix: decrease help columns

fix: crooked ui size rendering on startup

fix: various improvements

* don't add line numbers to markdown files
* fix selection active item styles
* fix selection readme styles
* add selection description styles

fix: add footer padding

fix: move repo readme into its own model

* fix refs switch flickering

fix: selection item truncate string

fix: footer padding

feat: repos list title & styles

fix: server cli interface

fix: simplify ui session struct

feat: selection tabs redesign

fix: no reference nil deref error

feat: add log commits loading

fix: replace tabs with space to avoid breaking files line wrapping

clean

fix(ui): selection box position when no repos

fix: log status bar after loading

fix: use actual repo name in status bar

fix(ui): styling after line breaks

fix(ui): subtle ui changes

* hide help from repo page
* file sizes now appear on the right side

fix(ui): show "no description" when a repo doesn't have one

fix(ui): glamour line wrapping

fix(ui): show footer on error

fix(ui): truncate repo clone cmd

fix(ui): truncate git clone command on repo page

fix(ui): truncate strings on small terminal width

fix(ui): switch to files tab on window resize

fix(examples): setuid imports

clean

fix: layout misc changes

fix: wrong dockerfile background highlight

fix(ui): styles on light terminal backgrounds

fix: don't use nerdfonts symbols

fix(git): cache head commits

fix(ui): loading commits spinner text

clear log selected commit after going back to commits log view

fix: respect private repos

Fixes: #81

feat: update deps
aymanbagabas added a commit that referenced this issue Jul 5, 2022
@aymanbagabas
feat(ui): new tui
acd0ad7 
wip: new ui

wip: selector

wip: header & footer

wip: selection readme

wip: add readme

wip: copy text

wip: fix readme wrap

wip: fix errorview margin

wip: underline filtered items

wip: add selector mouse wheel support

wip: fix reset formatting on line wraps

wip: initial repo ui implementation

wip: repo header

go mod tidy

add git branch symbol

fix: selector keymap

feat: display repo commits

feat: display commit diffs

godox

fix config tests

feat: render error in app style

feat: repo files tab

feat: add refs component

fix: glitches & add refs statusbar

feat: add full help toggle

fix: error view height

wip

init ui and check for errors

fix: initial repo

fix: url style

fix: selecting repo

feat: new log item style

feat: copy over ssh

clean

feat: detect private repos

feat: indicate private repos via emoji

feat: only show private repos for admins

feat: add files content line number

fix: bold selected file size

fix: remove header from repo page

fix: comitter & authored name highlight

fix: repo last updated time

feat: add statusbar symbols

fix: no repos

fix: prevent tab out of bound error

fix: decrease help columns

fix: crooked ui size rendering on startup

fix: various improvements

* don't add line numbers to markdown files
* fix selection active item styles
* fix selection readme styles
* add selection description styles

fix: add footer padding

fix: move repo readme into its own model

* fix refs switch flickering

fix: selection item truncate string

fix: footer padding

feat: repos list title & styles

fix: server cli interface

fix: simplify ui session struct

feat: selection tabs redesign

fix: no reference nil deref error

feat: add log commits loading

fix: replace tabs with space to avoid breaking files line wrapping

clean

fix(ui): selection box position when no repos

fix: log status bar after loading

fix: use actual repo name in status bar

fix(ui): styling after line breaks

fix(ui): subtle ui changes

* hide help from repo page
* file sizes now appear on the right side

fix(ui): show "no description" when a repo doesn't have one

fix(ui): glamour line wrapping

fix(ui): show footer on error

fix(ui): truncate repo clone cmd

fix(ui): truncate git clone command on repo page

fix(ui): truncate strings on small terminal width

fix(ui): switch to files tab on window resize

fix(examples): setuid imports

clean

fix: layout misc changes

fix: wrong dockerfile background highlight

fix(ui): styles on light terminal backgrounds

fix: don't use nerdfonts symbols

fix(git): cache head commits

fix(ui): loading commits spinner text

clear log selected commit after going back to commits log view

fix: respect private repos

Fixes: #81

feat: update deps
aymanbagabas added a commit that referenced this issue Aug 2, 2022
@aymanbagabas
feat(ui): new tui
1476c30 
wip: new ui

wip: selector

wip: header & footer

wip: selection readme

wip: add readme

wip: copy text

wip: fix readme wrap

wip: fix errorview margin

wip: underline filtered items

wip: add selector mouse wheel support

wip: fix reset formatting on line wraps

wip: initial repo ui implementation

wip: repo header

go mod tidy

add git branch symbol

fix: selector keymap

feat: display repo commits

feat: display commit diffs

godox

fix config tests

feat: render error in app style

feat: repo files tab

feat: add refs component

fix: glitches & add refs statusbar

feat: add full help toggle

fix: error view height

wip

init ui and check for errors

fix: initial repo

fix: url style

fix: selecting repo

feat: new log item style

feat: copy over ssh

clean

feat: detect private repos

feat: indicate private repos via emoji

feat: only show private repos for admins

feat: add files content line number

fix: bold selected file size

fix: remove header from repo page

fix: comitter & authored name highlight

fix: repo last updated time

feat: add statusbar symbols

fix: no repos

fix: prevent tab out of bound error

fix: decrease help columns

fix: crooked ui size rendering on startup

fix: various improvements

* don't add line numbers to markdown files
* fix selection active item styles
* fix selection readme styles
* add selection description styles

fix: add footer padding

fix: move repo readme into its own model

* fix refs switch flickering

fix: selection item truncate string

fix: footer padding

feat: repos list title & styles

fix: server cli interface

fix: simplify ui session struct

feat: selection tabs redesign

fix: no reference nil deref error

feat: add log commits loading

fix: replace tabs with space to avoid breaking files line wrapping

clean

fix(ui): selection box position when no repos

fix: log status bar after loading

fix: use actual repo name in status bar

fix(ui): styling after line breaks

fix(ui): subtle ui changes

* hide help from repo page
* file sizes now appear on the right side

fix(ui): show "no description" when a repo doesn't have one

fix(ui): glamour line wrapping

fix(ui): show footer on error

fix(ui): truncate repo clone cmd

fix(ui): truncate git clone command on repo page

fix(ui): truncate strings on small terminal width

fix(ui): switch to files tab on window resize

fix(examples): setuid imports

clean

fix: layout misc changes

fix: wrong dockerfile background highlight

fix(ui): styles on light terminal backgrounds

fix: don't use nerdfonts symbols

fix(git): cache head commits

fix(ui): loading commits spinner text

clear log selected commit after going back to commits log view

fix: respect private repos

Fixes: #81

feat: update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New UI charmbracelet/soft-serve
fix: respect private repos charmbracelet/soft-serve
2 participants
@grondinm @jackwilsdon