Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicode path in tui #457

Closed
daviehh opened this issue Jan 5, 2024 · 1 comment · Fixed by #492
Closed

unicode path in tui #457

daviehh opened this issue Jan 5, 2024 · 1 comment · Fixed by #492
Labels
bug Something isn't working

Comments

@daviehh
Copy link

daviehh commented Jan 5, 2024

Is your feature request related to a problem? Please describe.
In the "Files" view in the TUI, if the path is non-ascii, it shows the number like \343\201...

Describe the solution you'd like
Show unicode file/commit?

Thanks!

Screenshot 2024-01-04 at 9 49 32 PM
@aymanbagabas aymanbagabas added the bug Something isn't working label Jan 5, 2024
@jtams
Copy link

jtams commented Jan 7, 2024

I was able to reproduce the problem on MacOS/iTerm. The solution that worked for me was setting core.quotePath to false:

git config --global core.quotePath false

aymanbagabas added a commit that referenced this issue Mar 8, 2024
@aymanbagabas
fix: unquote git quoted filenames
91c10bf 
Git core.quotePath is enabled by default and causes unicode in filenames
to be quoted. Unquote filenames and requote them to escape control
characters BUT not unicode characters.

Fixes: #457
@aymanbagabas aymanbagabas mentioned this issue Mar 8, 2024
Merged
aymanbagabas added a commit that referenced this issue Mar 8, 2024
@aymanbagabas
fix: unquote git quoted filenames
7b97817 
Git core.quotePath is enabled by default and causes unicode in filenames
to be quoted. Unquote filenames and requote them to escape control
characters BUT not unicode characters.

Fixes: #457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unquote git quoted filenames charmbracelet/soft-serve
3 participants
@aymanbagabas @jtams @daviehh