-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Error from ParseLevel #83
Return Error from ParseLevel #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dezren39 for this work, a few comments below
will fix rest of file in follow-up commit Co-authored-by: Ayman Bagabas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 77.63% 80.25% +2.61%
==========================================
Files 10 10
Lines 635 699 +64
==========================================
+ Hits 493 561 +68
+ Misses 128 125 -3
+ Partials 14 13 -1
☔ View full report in Codecov by Sentry. |
Co-authored-by: Ayman Bagabas <[email protected]>
resolves #79
this adds an error result to the parse level function.
this change changes the return signature for ParseLevel!
users of ParseLevel will need to handle the error or choose to disregard it.
people will see the 'multiple values in a single context' error like below