-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix log.With() race condition #64
Conversation
- added small unittest to highlight the problem - only visible when running with -race option
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 76.77% 76.85% +0.07%
==========================================
Files 10 10
Lines 633 635 +2
==========================================
+ Hits 486 488 +2
Misses 132 132
Partials 15 15
|
Hi @alexvelea, thanks for the PR. I'm not able to reproduce the issue on |
Thanks for the fast reply @aymanbagabas |
I'm testing it against the latest commit from
|
@aymanbagabas, could you try again now, please? |
Also, make sure to run the tests on this branch. |
@alexvelea Ahh I see the issue now, could you re-push your changes again? |
@aymanbagabas done, tests are fixed now |
-race
option