Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Sub-logger #23

Closed
tomdotorg opened this issue Feb 25, 2023 · 2 comments
Closed

Docs: Sub-logger #23

tomdotorg opened this issue Feb 25, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@tomdotorg
Copy link
Contributor

Two things with the docs section on Sub-logger

  1. The code sample should begin with batch2 := log.With( instead of batch2 := logger.With(
  2. The animation of that example should show the two NV pairs the sub-logger contains.
@aymanbagabas aymanbagabas added the documentation Improvements or additions to documentation label Feb 25, 2023
@tomdotorg
Copy link
Contributor Author

If you don't mind, I can send you a PR for this one.

@tomdotorg tomdotorg mentioned this issue Feb 25, 2023
Merged
@aymanbagabas
Copy link
Member

This is now fixed in main

Malanris pushed a commit to Malanris/plog that referenced this issue Jul 29, 2024
@aymanbagabas
docs: update sublogger gify
4203894 
Fixes: charmbracelet/log#23
Related: charmbracelet/log#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomdotorg @aymanbagabas