fix: cache color profile and background #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition. Needs: muesli/termenv#146
caarlos0
approved these changes
Jul 31, 2023
|
|
||
| if !r.explicitColorProfile { | ||
| r.getColorProfile.Do(func() { | ||
| r.colorProfile = r.output.EnvColorProfile() |
There was a problem hiding this comment.
It looks like we do, but I think we don't need to since the function would only run once. Maybe @muesli can weigh on this
There was a problem hiding this comment.
Agree, the sync.Once already provides its own locking mechanism, so the read-lock should be sufficient. Could maybe add a comment in that regard to prevent further confusion.
|
|
||
| if !r.explicitBackgroundColor { | ||
| r.getBackgroundColor.Do(func() { | ||
| r.hasDarkBackground = r.output.HasDarkBackground() |
aymanbagabas
added a commit
to charmbracelet/log
that referenced
this pull request
Aug 1, 2023
Add `SetColorProfile` to force change the Lip Gloss renderer color profile. Needs: charmbracelet/lipgloss#212 Fixes: #63
aymanbagabas
added a commit
to charmbracelet/log
that referenced
this pull request
Aug 1, 2023
Add `SetColorProfile` to force change the Lip Gloss renderer color profile. Needs: charmbracelet/lipgloss#212 Fixes: #63
muesli
approved these changes
Aug 4, 2023
aymanbagabas
added a commit
to charmbracelet/log
that referenced
this pull request
Aug 22, 2023
Add `SetColorProfile` to force change the Lip Gloss renderer color profile. Needs: charmbracelet/lipgloss#212 Fixes: #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce caching the color profile and background