Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update chroma #154

Merged
merged 4 commits into from
Mar 8, 2023
Merged

feat: update chroma #154

merged 4 commits into from
Mar 8, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 31, 2022

latest and greatest, has more themes (gruvbox) and a bunch of other fixes.

only issues: needs go 1.17 - we're building on 1.13 👀

Signed-off-by: Carlos A Becker <[email protected]>
@caarlos0 caarlos0 requested a review from muesli May 31, 2022 18:43
@muesli
Copy link
Contributor

muesli commented Jun 24, 2022

1.17 is actually a bit problematic from a packaging perspective. I'll think about this one.

aymanbagabas added a commit that referenced this pull request Oct 17, 2022
aymanbagabas added a commit that referenced this pull request Oct 17, 2022
aymanbagabas added a commit that referenced this pull request Oct 17, 2022
@caarlos0
Copy link
Member Author

@muesli go 1.17 still an issue, right?

Copy link
Contributor

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 1.17 is go!

@caarlos0 caarlos0 requested a review from muesli March 8, 2023 13:28
@muesli muesli merged commit c783aea into master Mar 8, 2023
@muesli muesli deleted the chroma branch March 8, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants