ci: scan vulns and common errors (#310)

* ci: scan vulns and common errors

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: use go fuzz

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: using io.WriteString when it makes sense

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>

.github/workflows/build.yml

@@ -29,3 +29,16 @@ jobs:
       - name: Test
         run: go test ./...
         if: matrix.os != 'windows-latest'
+
+  govulncheck:
+    uses: charmbracelet/meta/.github/workflows/govulncheck.yml@main
+    with:
+      go-version: stable
+
+  semgrep:
+    uses: charmbracelet/meta/.github/workflows/semgrep.yml@main
+
+  ruleguard:
+    uses: charmbracelet/meta/.github/workflows/ruleguard.yml@main
+    with:
+      go-version: stable

ansi/baseelement.go

@@ -76,7 +76,7 @@ func renderText(w io.Writer, p termenv.Profile, rules StylePrimitive, s string)
 		out = out.Blink()
 	}
 
-	_, _ = w.Write([]byte(out.String()))
+	_, _ = io.WriteString(w, out.String())
 }
 
 func (e *BaseElement) Render(w io.Writer, ctx RenderContext) error {

ansi/blockelement.go

@@ -38,8 +38,7 @@ func (e *BlockElement) Finish(w io.Writer, ctx RenderContext) error {
 		}
 
 		if e.Newline {
-			_, err = mw.Write([]byte("\n"))
-			if err != nil {
+			if _, err := io.WriteString(mw, "\n"); err != nil {
 				return err
 			}
 		}

ansi/paragraph.go

@@ -18,7 +18,7 @@ func (e *ParagraphElement) Render(w io.Writer, ctx RenderContext) error {
 	rules := ctx.options.Styles.Paragraph
 
 	if !e.First {
-		_, _ = w.Write([]byte("\n"))
+		_, _ = io.WriteString(w, "\n")
 	}
 	be := BlockElement{
 		Block: &bytes.Buffer{},
@@ -46,7 +46,7 @@ func (e *ParagraphElement) Finish(w io.Writer, ctx RenderContext) error {
 		if err != nil {
 			return err
 		}
-		_, _ = mw.Write([]byte("\n"))
+		_, _ = io.WriteString(mw, "\n")
 	}
 
 	renderText(w, ctx.options.ColorProfile, bs.Current().Style.StylePrimitive, rules.Suffix)

ansi/renderer.go

@@ -103,7 +103,7 @@ func (r *ANSIRenderer) renderNode(w util.BufWriter, source []byte, node ast.Node
 			writeTo = io.Writer(bs.Current().Block)
 		}
 
-		_, _ = writeTo.Write([]byte(e.Entering))
+		_, _ = io.WriteString(writeTo, e.Entering)
 		if e.Renderer != nil {
 			err := e.Renderer.Render(writeTo, r.context)
 			if err != nil {
@@ -128,7 +128,8 @@ func (r *ANSIRenderer) renderNode(w util.BufWriter, source []byte, node ast.Node
 				return ast.WalkStop, err
 			}
 		}
-		_, _ = bs.Current().Block.Write([]byte(e.Exiting))
+
+		_, _ = io.WriteString(bs.Current().Block, e.Exiting)
 	}
 
 	return ast.WalkContinue, nil

glamour_test.go

@@ -260,3 +260,15 @@ func TestCapitalization(t *testing.T) {
 		t.Errorf("Rendered output doesn't match!\nExpected: `\n%s`\nGot: `\n%s`\n", td, b)
 	}
 }
+
+func FuzzData(f *testing.F) {
+	f.Fuzz(func(t *testing.T, data []byte) {
+		func() int {
+			_, err := RenderBytes(data, DarkStyle)
+			if err != nil {
+				return 0
+			}
+			return 1
+		}()
+	})
+}