Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add another progress bar example #270

Merged
merged 2 commits into from
Jun 15, 2022
Merged

docs: add another progress bar example #270

merged 2 commits into from
Jun 15, 2022

Conversation

bashbunni
Copy link
Member

@bashbunni bashbunni commented Mar 31, 2022 •
edited
Loading

Changes Made:

  • add example for having progress bar when downloading a file.
  • show how to use the example

@bashbunni
Copy link
Member Author

Will reply to charmbracelet/bubbles#127 with a link to this working example once this has been merged to master

@bashbunni bashbunni added the documentation Improvements or additions to documentation label Apr 3, 2022
@bashbunni bashbunni force-pushed the examples/download-progress branch 2 times, most recently from 1d398e1 to b7c663c Compare April 8, 2022 21:15
@bashbunni bashbunni requested a review from meowgorithm April 8, 2022 22:17
@bashbunni bashbunni force-pushed the examples/download-progress branch 2 times, most recently from 184d8b9 to 2613b70 Compare May 6, 2022 03:37
@bashbunni bashbunni force-pushed the examples/download-progress branch from 2613b70 to 5dfbef6 Compare May 6, 2022 04:50
@bashbunni
Copy link
Member Author

Just squashed everything to one commit

@bashbunni
Copy link
Member Author

@meowgorithm can I rebase and merge this to master?

@meowgorithm
Copy link
Member

meowgorithm commented Jun 15, 2022 •
edited
Loading

@bashbunni Go for it. I made some small copy edits to the README so please squash ’n merge. Thanks of much for adding this one!

@meowgorithm meowgorithm force-pushed the examples/download-progress branch from 2392bec to 46eb3c0 Compare June 15, 2022 18:39
@meowgorithm meowgorithm force-pushed the examples/download-progress branch from 46eb3c0 to 694a104 Compare June 15, 2022 18:42
@bashbunni bashbunni merged commit a2d0ac9 into master Jun 15, 2022
@meowgorithm meowgorithm deleted the examples/download-progress branch June 21, 2022 14:02
shivan-s added a commit to shivan-s/bubbletea that referenced this pull request Jun 22, 2022
@shivan-s
Revert "docs: add another progress bar example (charmbracelet#270)"
5fd827b 
This reverts commit a2d0ac9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

Assignees

@meowgorithm meowgorithm

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashbunni @meowgorithm